-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-2727 - Implement AddressInput module component #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgero-eth
force-pushed
the
feat-APP-2727-implement-input-address
branch
2 times, most recently
from
March 13, 2024 14:35
0a48dda
to
4b68af2
Compare
cgero-eth
changed the title
WIP feat: APP-2727 - Implement AddressInput module component
feat: APP-2727 - Implement AddressInput module component
Mar 13, 2024
cgero-eth
force-pushed
the
feat-APP-2727-implement-input-address
branch
2 times, most recently
from
March 14, 2024 11:22
86c6e5d
to
ddafac1
Compare
11 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, 0xrugg! Very nice work; clean and efficient.
src/modules/components/odsModulesProvider/odsModulesProvider.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/address/addressInput/addressInput.test.tsx
Outdated
Show resolved
Hide resolved
cgero-eth
force-pushed
the
feat-APP-2727-implement-input-address
branch
from
March 15, 2024 15:21
4c1e4d4
to
7c3dc79
Compare
Fabricevladimir
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Left a couple comments. 👍🏾
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AddressInput
module componentTask: APP-2727
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.