Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2727 - Implement AddressInput module component #123

Merged
merged 41 commits into from
Mar 19, 2024
Merged

feat: APP-2727 - Implement AddressInput module component #123

merged 41 commits into from
Mar 19, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Mar 12, 2024 •
edited
Loading

Description

  • Implement AddressInput module component
  • Update default query-client options to set a stale time greater than 0

Task: APP-2727

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth force-pushed the feat-APP-2727-implement-input-address branch 2 times, most recently from 0a48dda to 4b68af2 Compare March 13, 2024 14:35
@cgero-eth cgero-eth changed the title WIP feat: APP-2727 - Implement AddressInput module component feat: APP-2727 - Implement AddressInput module component Mar 13, 2024
@cgero-eth cgero-eth marked this pull request as ready for review March 13, 2024 14:38
@cgero-eth cgero-eth requested a review from a team March 13, 2024 14:38
@cgero-eth cgero-eth force-pushed the feat-APP-2727-implement-input-address branch 2 times, most recently from 86c6e5d to ddafac1 Compare March 14, 2024 11:22
@sepehr2github sepehr2github mentioned this pull request Mar 15, 2024
Merged
11 tasks
Fabricevladimir
Fabricevladimir reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 0xrugg! Very nice work; clean and efficient.

src/modules/components/odsModulesProvider/odsModulesProvider.tsx Outdated Show resolved Hide resolved
src/modules/components/member/memberAvatar/memberAvatar.test.tsx Show resolved Hide resolved
src/modules/utils/addressUtils/addressUtils.tsx Outdated Show resolved Hide resolved
src/modules/utils/addressUtils/addressUtils.tsx Outdated Show resolved Hide resolved
src/modules/utils/ensUtils/ensUtils.ts Outdated Show resolved Hide resolved
src/modules/components/address/addressInput/addressInput.tsx Show resolved Hide resolved
src/modules/components/address/addressInput/addressInput.tsx Outdated Show resolved Hide resolved
src/modules/components/address/addressInput/addressInput.tsx Outdated Show resolved Hide resolved
src/modules/components/address/addressInput/addressInput.tsx Outdated Show resolved Hide resolved
src/modules/components/address/addressInput/addressInput.test.tsx Outdated Show resolved Hide resolved
@cgero-eth
Create component structure
07ae8fa
@cgero-eth
Implement initial functionalities of address-input component
30d2e4d
@cgero-eth
Cleanup implementation, handle changing value programmatically
53f5bb7
@cgero-eth
Implement copy & block-explorer buttons
8e4478c
@cgero-eth
Update address-input implementation
dba958e
@cgero-eth
Remove truncate from inputs, display copy button whenever there's a v…
03a28c6 
…alue set
@cgero-eth
Debounce RPC requests
e2dd5b1
@cgero-eth
Implement tests for useDebouncedValue hook
7e2b3f7
@cgero-eth
Implement tests for clipboard utils
ed3c4cc
@cgero-eth
Implement tests for address-utils, correctly setup wagmi for testing
025a48f
@cgero-eth
Export useInputProps from core package, start implementation of tests
a4f8f8f
@cgero-eth
Fix displaying of buttons, check if current chain-id supports ens names
cbfc26f
@cgero-eth
Implement more tests
0db9148
@cgero-eth
Update address and ens utils
13e9c78
@cgero-eth
Truncate long ens names on address-input component
b04f7ea
@cgero-eth
Update addressInput.test.tsx
d92a675
@cgero-eth
Update member-avatar to use address/ens utilities
5f542b2
@cgero-eth
Add return valud to copy function
ac820fd
@cgero-eth
Use Address type instead of Hash
c37a809
@cgero-eth
Cleanup member-avatar test setup
9405659
@cgero-eth
Reset mocks
6025173
@cgero-eth cgero-eth force-pushed the feat-APP-2727-implement-input-address branch from 4c1e4d4 to 7c3dc79 Compare March 15, 2024 15:21
Fabricevladimir
Fabricevladimir approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Left a couple comments. 👍🏾

Fabricevladimir
Fabricevladimir reviewed Mar 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@cgero-eth cgero-eth merged commit 162543f into main Mar 19, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat-APP-2727-implement-input-address branch March 19, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @Fabricevladimir